Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exposeUnsetFields when useDefineForClassFields is set #1689

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: exposeUnsetFields when useDefineForClassFields is set #1689

wants to merge 2 commits into from

Conversation

fjodor-rybakov
Copy link

Description

When useDefineForClassFields is true in tsconfig option exposeUnsetFields doesn't work. This pull request make force exposeUnsetFields to remove property from class if finalValue is undefined

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

@NoNameProvided NoNameProvided changed the title Fix: exposeUnsetFields when useDefineForClassFields is set fix: exposeUnsetFields when useDefineForClassFields is set May 4, 2024
@fjodor-rybakov
Copy link
Author

@NoNameProvided Any updates? This is a critical and non-obvious bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fjodor-rybakov